Simple-Contacts: Added support for relations#1649
Open
rlieger wants to merge 2 commits intoSimpleMobileTools:masterfrom
Open
Simple-Contacts: Added support for relations#1649rlieger wants to merge 2 commits intoSimpleMobileTools:masterfrom
rlieger wants to merge 2 commits intoSimpleMobileTools:masterfrom
Conversation
added 2 commits
March 27, 2023 18:33
…daughter) to be stored in contacts (both Android ContactContract and LocalContact).
Author
|
This pull request was not handled for three weeks. I have since worked a lot on the code and hope to release an improved version within a week or two. I suggest that you skip this version and directly integrate the new version. |
Contributor
then I guess this one can be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ContactRelation can be used to express a relation to another person (e.g. spouse, friend, colleague) within a contact. This concept is supported by both Android (ContactContract.Relation) and vCard 4.0 (RELATED) and should thus also be supported in SimpleContacts.
Note: Like most fields, displaying relations for a contact is optional and can be enabled/disabled in the manage-visable-fields dialog. It is disabled by default, so to see my code in action be sure to enable it...
I have added suitable code for both the base types (in Simple-Commons) and the application logic for the viewing/editing the databases (in Simple-Contacts). Thus to obtain a working system, pulling both Simple-Commons and Simple-Contacts is necessary!